refactor: move slack url creation to its own package#5225
refactor: move slack url creation to its own package#5225santiagofn wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
Signed-off-by: Santiago Fernández Núñez <santiago.nunez@nubank.com.br>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SoloJacobs
left a comment
SoloJacobs
left a comment
There was a problem hiding this comment.
It looks like this was largely AI-generated. We'd ask that contributions be reviewed and understood by the author before submitting, including making sure the commit message accurately describes what the code actually does. The message here says "refactor" but the change alters behavior. Happy to look at it again once it's been properly reviewed on your end.
2 participants
Part 2 of a series implementing threaded message support for the Slack notifier. Full picture: #5150. Depends on #5224.
Summary
Extracts Slack API URL resolution logic from
slack.gointo a new internal packagenotify/slack/internal/apiurl. Adds comprehensive unit tests covering all resolution paths (direct URL, file-based, global config).